Announcement

Collapse
No announcement yet.

Syntax Errors in Image_ResizeIntoBoundingBox()

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Syntax Errors in Image_ResizeIntoBoundingBox()

    In util_public.mv the function Image_ResizeIntoBoundingBox() contains two syntax errors that prevent it from working.

    1. The parameter sourcefile_path is called as
    Image_Type( l.sourcefilepath, l.source_location, l.sourcefile_type )

    2. The parameter source_location is called as
    Image_gdCreateFromFile_Type( l.sourcefile_type, l.sourcefile_path, l.sourcefile_location )

    With those two problems fixed and recompiled, I think it works as expected but the function needs to be tested by Miva.

    While your at it, returning g.Image_ResizeIntoBoundingBox_error to explain why any part of this function fails would be helpful.
    Ray Yates
    "If I have seen further, it is by standing on the shoulders of giants."
    --- Sir Isaac Newton

    #2
    Re: Syntax Errors in Image_ResizeIntoBoundingBox()

    Thanks for the report Ray, I've filed a bug and we'll get it fixed in a future version.

    Error messages should already be available in g.Error_Message.

    Comment


      #3
      Re: Syntax Errors in Image_ResizeIntoBoundingBox()

      Jon

      What version of the gd library is included in MivaScript?
      Ray Yates
      "If I have seen further, it is by standing on the shoulders of giants."
      --- Sir Isaac Newton

      Comment


        #4
        Re: Syntax Errors in Image_ResizeIntoBoundingBox()

        None. We dynamically load whatever gd library is installed on the server, or is specified by the Miva configuration.

        Comment


          #5
          Re: Syntax Errors in Image_ResizeIntoBoundingBox()

          Yes of course. Then can I assume the latest version for the documentation 2.033

          http://www.boutell.com/gd/manual2.0.33.html
          Ray Yates
          "If I have seen further, it is by standing on the shoulders of giants."
          --- Sir Isaac Newton

          Comment


            #6
            Re: Syntax Errors in Image_ResizeIntoBoundingBox()

            Most modern Linux distributions come with 2.0.34 these days. However, it would still be a good idea to expect certain functions to fail occasionally (the TrueColor functions, for example) and provide fallback code that handles those failures.

            Comment

            Working...
            X