Announcement

Collapse
No announcement yet.

Same As Shipping Checkbox Issue

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Same As Shipping Checkbox Issue

    Am I the only person seeing this? If you go to the bootstrap readytheme demo, proceed to checkout, checkout as guest, and then try checking the "Same As Shipping" checkbox, the behavior is jacked.

    Instead of hiding upon being checked, it DOESN'T hide. If you un-check it, it will hide, check it again, it shows up.

    Anyone else seeing this? I've confirmed it does it on the base readytheme demo here (http://readytheme-framework.mivamerchantdev.com/) as well as 5 or 6 of my clients sites that we used that theme as the starter.
    Ted Hust
    AarcMediaGroup.com

    Celebrating 13 Years of Outstanding Service & Support
    Miva Merchant Design

    #2
    Re: Same As Shipping Checkbox Issue

    Same thing happening on our site. Just noticed it today and am searching for a fix.
    Joe McDonald
    patrickwebby.com

    Comment


      #3
      Re: Same As Shipping Checkbox Issue

      I'll check with our developers on this.
      David Hubbard
      CIO
      Miva
      [email protected]
      http://www.miva.com

      Comment


        #4
        Re: Same As Shipping Checkbox Issue

        What browser are you using? I just tried it is chrome and it is working correctly for me.
        Brennan Heyde
        VP Product
        Miva, Inc.
        [email protected]
        https://www.miva.com

        Comment


          #5
          Re: Same As Shipping Checkbox Issue

          It's happening to me in both Chrome and Firefox. I thought maybe I had dragged my feet through the code someplace but then I saw the original post on this thread. www. wetsuitwearhouse.com is where I'm seeing it.
          Joe McDonald
          patrickwebby.com

          Comment


            #6
            Re: Same As Shipping Checkbox Issue

            I'm seeing it now. It works correctly in Chrome Mac but not on PC. I'll take a look and post a fix shortly.
            Last edited by Brennan; 09-23-15, 12:38 PM.
            Brennan Heyde
            VP Product
            Miva, Inc.
            [email protected]
            https://www.miva.com

            Comment


              #7
              Re: Same As Shipping Checkbox Issue

              OK, I found the issue. There was some legacy JS code inside mm5/js/custom.js that we added because our built in JS at the time used visibility:visible vs display:none to hide the fields. This caused some layout issues on mobile when hiding the fields. This has since been fixed in the core JS, or our custom code can be removed.

              In the mm5/js/custom.js file make:

              Code:
              
                  JS_OCST: function () {
              
              
              
              
              
              
                      $('#ocst_form').find('select').addClass('form-control');
              
              
              
              
              
              
              
              
              
              
              
              
              
              
                      if ($('#shipping_controls').is(':visible')) {
              
              
              
              
              
              
                          if ($('#shipping_to_show').is(':checked')) {
              
              
              
              
              
              
                              $('#shipping_fields').hide();
              
              
              
              
              
              
                          };
              
              
              
              
              
              
                          $('#shipping_to_show').on('change', function () {
              
              
              
              
              
              
                              $('#shipping_fields').toggle();
              
              
              
              
              
              
                          });
              
              
              
              
              
              
                      };
              
              
              
              
              
              
                      if ($('#billing_controls').is(':visible')) {
              
              
              
              
              
              
                          if ($('#billing_to_show').is(':checked')) {
              
              
              
              
              
              
                              $('#billing_fields').hide();
              
              
              
              
              
              
                          };
              
              
              
              
              
              
                          $('#billing_to_show').on('change', function () {
              
              
              
              
              
              
                              $('#billing_fields').toggle();
              
              
              
              
              
              
                          });
              
              
              
              
              
              
                      };
              
              
              
              
              
              
                  },

              to


              Code:
              
              
              
              
                  JS_OCST: function () {
              
              
              
              
              
              
                      $('#ocst_form').find('select').addClass('form-control');
              
              
              
              
              
              
              
              
              
              
                  },
              We'll push out an update to the framework soon as well.
              Last edited by Brennan; 09-23-15, 01:01 PM.
              Brennan Heyde
              VP Product
              Miva, Inc.
              [email protected]
              https://www.miva.com

              Comment


                #8
                Re: Same As Shipping Checkbox Issue

                That did it. Aren't you glad I'm sitting and staring at Miva admin's all day so I can catch this sort of stuff :)

                You don't want to know how long I spent trying to figure this out myself. Way longer than I should have considering the forum was built for this sort of thing.
                Ted Hust
                AarcMediaGroup.com

                Celebrating 13 Years of Outstanding Service & Support
                Miva Merchant Design

                Comment


                  #9
                  Re: Same As Shipping Checkbox Issue

                  Worked for me as well.

                  Thanks for the fast work on this! Glad I'm not losing my mind :)
                  Joe McDonald
                  patrickwebby.com

                  Comment

                  Working...
                  X